Remove embedded-hal 0.2.x impls and dependency from esp-lp-hal package
#2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be fair, we may just go on with the removal without adding ehal 1.0 support in this PR. |
|
Yeah, this package is not worth investing any time into right now IMO. |
playfulFence
force-pushed
the
feat/eh2
branch
from
6c4828f
to
e3ef6ae
Compare
|
Ok, then let's just make those functions for |
playfulFence
force-pushed
the
feat/eh2
branch
from
e3ef6ae
to
afedbfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details 📖
Description
closes #2597
For
LpI2cwe need to implement theembedded_hal::i2c:I2ctrait instead ofembedded-hal 0.2.7ones.But for now, let's just rename current methods to match common "write"/"read" format and make them public
Testing
examples